Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin: detroit_authority is broken #23

Closed
rhetr opened this issue Jul 29, 2022 · 0 comments
Closed

Mixin: detroit_authority is broken #23

rhetr opened this issue Jul 29, 2022 · 0 comments

Comments

@rhetr
Copy link
Collaborator

rhetr commented Jul 29, 2022

affected spiders

  • det_brownfield_redevelopment_authority.py
  • det_downtown_development_authority.py
  • det_economic_development_corporation.py
  • det_eight_mile_woodward_corridor_improvement_authority.py
  • det_local_development_finance_authority.py
  • det_neighborhood_development_corporation.py
  • det_next_michigan_development_corporation.py

proposed solution

short term: scrape the embedded yoast schema graph to graph the information
long term: create a new mixin using the wordpress events calendar API as mentioned in #22

status

i created a branch in my fork and updated the scraper to parse the yoast schema graph; however, the tests are failing. I'm unsure if it is imperative to fix the tests since we plan to overhaul the mixin in the near future anyway.

it's also unclear to me the exact purpose of _parse_prev_meetings() but it doesn't seem to be broken so i have not modified it.

@rhetr rhetr changed the title detroit_authority mixin is broken Mixin: detroit_authority is broken Jul 29, 2022
@rhetr rhetr closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant