Remove right_of_occupancy_payment logic #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvalimaa
reviewed
May 30, 2024
tvalimaa
reviewed
May 30, 2024
tvalimaa
reviewed
May 30, 2024
| @@ -4,7 +4,6 @@ describe('getApartmentPrice', () => { | |||
| it("should return '-' if is haso and both release_payment and right_of_occupancy_payment is null", () => { | |||
There was a problem hiding this comment.
right_of_occupancy_payment field is removed
If release_payment exists use it as price, if not use haso_fee. The right_of_occupancy_payment is no longer used in the Apartment object. Removed right_of_occupancy_payment from Apartment, added haso_fee.
|
rbreve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If release_payment exists use it as price, if not use haso_fee. The right_of_occupancy_payment is no longer used in the Apartment object. Removed right_of_occupancy_payment from Apartment, added haso_fee.