Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8730 tpr unit new field tests #149

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Conversation

dire
Copy link
Contributor

@dire dire commented Jul 13, 2023

UHF-8730

What was done?

  • Added tests for the new connection fields.

How to install

  • Make sure your instance is up and running on correct branch.
    • make fresh
  • Run composer require drupal/helfi_platform_config:dev-UHF-8730_Unit-new-field-tests

How to test

Run following in the /app inside the container.

  • Run vendor/bin/phpunit -c /app/phpunit.xml.dist public/modules/contrib/helfi_tpr/tests/src/Unit/ConnectionRepositoryTest.php
  • Run vendor/bin/phpunit -c /app/phpunit.xml.dist public/modules/contrib/helfi_tpr/tests/src/Unit/ConnectionTest.php
  • Run vendor/bin/phpunit -c /app/phpunit.xml.dist public/modules/contrib/helfi_tpr/tests/src/Kernel/UnitMigrationTest.php

All tests should pass.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #149 (d00c8c5) into main (d44cc81) will increase coverage by 1.55%.
The diff coverage is 100.00%.

❗ Current head d00c8c5 differs from pull request most recent head c74ce5b. Consider uploading reports for the commit c74ce5b to get more accurate results

@@             Coverage Diff              @@
##               main     #149      +/-   ##
============================================
+ Coverage     79.90%   81.46%   +1.55%     
- Complexity      353      354       +1     
============================================
  Files            49       49              
  Lines          2732     2762      +30     
============================================
+ Hits           2183     2250      +67     
+ Misses          549      512      -37     
Impacted Files Coverage Δ
src/Entity/Unit.php 94.71% <100.00%> (-0.47%) ⬇️
src/Fixture/Unit.php 99.86% <100.00%> (+<0.01%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants