Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9150: modify schoolyear settings and TPR ontologyword details name #160

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Nov 7, 2023

What was done

  • Move helfi_school_addons files under helfi_kasko_content module
  • Remove id prefix from TPR ontologyword details name

Check testing instructions from: https://github.com/City-of-Helsinki/drupal-helfi-kasvatus-koulutus/pull/479/files

@Jussiles Jussiles changed the title UHF-9150: import more ontology words UHF-9150: modify schoolyear settings and ontologyword details name Nov 7, 2023
@Jussiles Jussiles changed the title UHF-9150: modify schoolyear settings and ontologyword details name UHF-9150: modify schoolyear settings and TPR ontologyword details name Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #160 (fe2eae0) into main (96e148e) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is 75.00%.

❗ Current head fe2eae0 differs from pull request most recent head 0e6946a. Consider uploading reports for the commit 0e6946a to get more accurate results

@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
- Coverage     81.41%   81.38%   -0.03%     
  Complexity      356      356              
============================================
  Files            49       49              
  Lines          2809     2810       +1     
============================================
  Hits           2287     2287              
- Misses          522      523       +1     
Files Coverage Δ
src/Plugin/migrate/source/OntologyWordDetails.php 89.47% <100.00%> (ø)
src/Entity/OntologyWordDetails.php 56.25% <0.00%> (-1.82%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants