feat: sports locations support #141
Conversation
|
Events Graphql Federation Router for sports is deployed to: https://events-helsinki-monorepo-sports-locations-e9.test.kuva.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-sports-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Events Graphql Federation Router for hobbies is deployed to: https://events-helsinki-monorepo-sports-locations-ea.test.kuva.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-events-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-hobbies-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Events Graphql Federation Router for events is deployed to: https://events-helsinki-monorepo-sports-locations-a2.test.kuva.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-events-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-sports-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-hobbies-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-sports-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Federation Router branch is deployed to platta: https://events-graphql-federation-events-pr141.dev.hel.ninja 🚀🚀🚀 |
There was a problem hiding this comment.
The changes looks good to me. I would rename the "Locations" to "Venues". I didn't approve this yet since there is that "Don't merge" -comment because of the unmatching structure of the CMS-sources. Also the Federation-Router changes should be added to a different PR, so that it can be merged before this one. The new changes are not yet active in the staging environment what this PR-review is using.
melniiv
force-pushed
the
sports-locations
branch
from
0e12126
to
ab6b2c3
Compare
|
Sports-Helsinki branch is deployed to platta: https://liikunta-pr141.dev.hel.ninja 🚀🚀🚀 |
|
I heard the CMS staging server instances should now share the same version, plugins and data structure. There are some new modules and types also! The schema needs to be recreated!. For example a new page module called LocationSelectedCarousel was added.
|
melniiv
force-pushed
the
sports-locations
branch
from
ab6b2c3
to
55b1507
Compare
|
Sports-Helsinki branch is deployed to platta: https://liikunta-pr141.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://liikunta-pr141.dev.hel.ninja 😆🎉🎉🎉 |
|
Sports-Helsinki branch is deployed to platta: https://liikunta-pr141.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://liikunta-pr141.dev.hel.ninja 😆🎉🎉🎉 |
|
Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Events-Helsinki branch is deployed to platta: https://tapahtumat-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Sports-Helsinki branch is deployed to platta: https://liikunta-pr141.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://harrastukset-pr141.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://tapahtumat-pr141.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://liikunta-pr141.dev.hel.ninja 😆🎉🎉🎉 |
|
SonarCloud Quality Gate failed. |
|
SonarCloud Quality Gate failed. |
|
Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr141.dev.hel.ninja 🚀🚀🚀 |
|
Events-Helsinki branch is deployed to platta: https://tapahtumat-pr141.dev.hel.ninja 🚀🚀🚀 |
|
SonarCloud Quality Gate failed. |
|
Sports-Helsinki branch is deployed to platta: https://liikunta-pr141.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is failed for https://harrastukset-pr141.dev.hel.ninja 😿💢💥💥 |
TestCafe result is failed for https://tapahtumat-pr141.dev.hel.ninja 😿💢💥💥 |
TestCafe result is failed for https://liikunta-pr141.dev.hel.ninja 😿💢💥💥 |
TestCafe result is failed for https://tapahtumat-pr141.dev.hel.ninja 😿💢💥💥 |
TestCafe result is failed for https://harrastukset-pr141.dev.hel.ninja 😿💢💥💥 |
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable */ | |||
Description
Support of the sports locations
Updated schemas are not supoorted in events staging, so it will break the staging if merged. LocationsSelected missing from modules in staging and has to be fixed by headless cms team. But it should work with production headless cms
Issues
Closes
DEV-XXX:
Related
Testing
Automated tests
Manual testing
Screenshots
Additional notes