Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: layout heights improvements #213

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: layout heights improvements #213

merged 1 commit into from
Feb 10, 2023

Conversation

melniiv
Copy link
Contributor

@melniiv melniiv commented Feb 10, 2023

Description

-Fixed footer on bottom for the venues search page
-Fixed tab buttons hover color in sports search
-Fixed articles height layout issues (hcrc)

Issues

Closes

DEV-XXX:

Related

Testing

Automated tests

Manual testing

Screenshots

Additional notes

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr213.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr213.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr213.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr213.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr213.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr213.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr213.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr213.dev.hel.ninja 😆🎉🎉🎉

@melniiv melniiv merged commit f26248c into main Feb 10, 2023
This was referenced Feb 10, 2023
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Closed
@github-actions github-actions bot mentioned this pull request Mar 17, 2023
Merged
This was referenced Mar 30, 2023
Merged
Merged
This was referenced Jan 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomakela nikomakela nikomakela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melniiv @terovirtanen @nikomakela