Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-1833 Link size and prop changes #1275

Merged

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Apr 29, 2024

Description

Link size to enum and icon left to icon start and some small fixes too.

Related Issue

HDS-1833

How Has This Been Tested?

  • local machine running all tests

Demos:

Docs

Core Storybook

React Storybook

Add to changelog

  • Added needed line to changelog

@mrTuomoK mrTuomoK requested a review from a team April 29, 2024 08:41
@mrTuomoK mrTuomoK force-pushed the HDS-1833-Link-size-to-enum-and-iconLeft-to-iconStart branch from cbdbdd2 to 70b0bff Compare April 29, 2024 10:56
@laurakarhu laurakarhu added the Breaking changes Issue or pull request that includes breaking changes. label May 3, 2024
@laurakarhu laurakarhu added this to the HDS 4.0.0 milestone May 3, 2024
DannyFranklin

This comment was marked as spam.

Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job! Added two questions, not really related to this PR.

packages/react/src/components/link/Link.tsx Show resolved Hide resolved
packages/react/src/components/link/Link.tsx Show resolved Hide resolved
@mrTuomoK mrTuomoK merged commit 9e24d85 into release-4.0.0 Jun 3, 2024
7 checks passed
@mrTuomoK mrTuomoK deleted the HDS-1833-Link-size-to-enum-and-iconLeft-to-iconStart branch June 3, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes Issue or pull request that includes breaking changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants