Prepare release 0.2.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unknown what's the real reason behind this version limitation. My guess is it was there because Tunnistamo puts the `amr` claim into JWTs as a string, while according to specifications it should be an array of strings. Django-helusers is used for checking the JWTs and it uses drf-oidc-auth for the heavy lifting. Drf-oidc-auth versions >=1.0.0 demand the `amr` claim to be standards compliant and thus refuse to accept Tunnistamo JWTs. However, there is now a fix for this in django-helusers [1], which allows using newer versions of drf-oidc-auth. [1] City-of-Helsinki/django-helusers@95a7421
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 5 5
Lines 148 148
Branches 24 24
=======================================
Hits 140 140
Misses 4 4
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Also update django-helusers, which uses drf-oidc-auth, to the newest version.
akikoskinen
force-pushed
the
prepare-release-0.2.0
branch
from
0eb29ea
to
808dcd3
Compare
mikkokeskinen
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.