LINK-1765, LINK-1766 | Refactor tables #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr336-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedcomponents-pr336-ui.dev.hel.ninja 😆🎉🎉🎉 |
|
LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr336-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedcomponents-pr336-ui.dev.hel.ninja 😆🎉🎉🎉 |
jorilindell
changed the title
jorilindell
force-pushed
the
fix/LINK-1765_refactor-tables
branch
from
573f2c5
to
ab088d8
Compare
|
LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr336-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedcomponents-pr336-ui.dev.hel.ninja 😆🎉🎉🎉 |
jorilindell
force-pushed
the
fix/LINK-1765_refactor-tables
branch
from
ab088d8
to
11e34c1
Compare
jorilindell
force-pushed
the
fix/LINK-1765_refactor-tables
branch
from
11e34c1
to
2003c73
Compare
|
|
LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr336-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is failed for https://linkedcomponents-pr336-ui.dev.hel.ninja 😿💢💥💥 |
1 similar comment
e2e tests result is failed for https://linkedcomponents-pr336-ui.dev.hel.ninja 😿💢💥💥 |
harriris-vincit
approved these changes
Mar 4, 2024
e2e tests result is success for https://linkedcomponents-pr336-ui.dev.hel.ninja 😆🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace all tables to use (excluding tables with collapsible content) HDS Table component.
HDS Table doesn't support clickable rows so replace them by making item name or id to work as a link.
Add column header for the tables with action buttons. Make that column to be visible only to screen readers.
Closes
LINK-1765
LINK-1766