Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINK-2051 | hide instruction notifications from admin users #411

Merged
merged 1 commit into from
Jun 22, 2024
Merged

LINK-2051 | hide instruction notifications from admin users #411

merged 1 commit into from
Jun 22, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Jun 13, 2024 •
edited by jira bot
Loading

Description

Hide instruction notifications from admin users. Instead show tooltip instructions for them.

Note that it's intentional to display "Julkaisu" instruction for all the users.

Closes

LINK-2051

Screenshot

Screenshot 2024-06-13 at 17 01 25 Screenshot 2024-06-13 at 16 59 49

@jorilindell jorilindell requested review from harriris-vincit and a team June 13, 2024 14:05
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr411-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://linkedcomponents-pr411-ui.dev.hel.ninja 😿💢💥💥

@jorilindell jorilindell force-pushed the feature/LINK-2051_hide-instruction-notifications-from-admin branch from f7ff0d9 to e6dfd4a Compare June 14, 2024 08:03
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr411-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr411-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-2051_hide-instruction-notifications-from-admin branch from e6dfd4a to 13a33b1 Compare June 19, 2024 13:32
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr411-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr411-ui.dev.hel.ninja 😆🎉🎉🎉

harriris-vincit
harriris-vincit approved these changes Jun 20, 2024
View reviewed changes
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though should be tested with a screenreader to ensure it knows about the popup being opened.

@jorilindell jorilindell force-pushed the feature/LINK-2051_hide-instruction-notifications-from-admin branch from 13a33b1 to 2b2ddfa Compare June 21, 2024 11:09
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr411-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr411-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-2051_hide-instruction-notifications-from-admin branch from 2b2ddfa to 79e36c0 Compare June 21, 2024 11:32
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr411-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr411-ui.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jorilindell
Copy link
Contributor Author

Looks good, though should be tested with a screenreader to ensure it knows about the popup being opened.

Tested Tooltip component with NVDA and I works as expected

@jorilindell jorilindell merged commit 1c40012 into main Jun 22, 2024
20 checks passed
@jorilindell jorilindell deleted the feature/LINK-2051_hide-instruction-notifications-from-admin branch June 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harriris-vincit harriris-vincit harriris-vincit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorilindell @terovirtanen @harriris-vincit