Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1853 | Add timeout to SingleSelectComponent value change #123

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Jan 15, 2024

Description

  • Android devices freezes totally when trying to change value of a SingleSelectComponent. Add a short timeout to prevent infinite loop after calling onChange.

Closes

LINK-1853

@jorilindell jorilindell requested review from harriris-vincit and a team January 15, 2024 09:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0ec760) 99.53% compared to head (61ea401) 99.53%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files         188      188           
  Lines        3647     3648    +1     
  Branches      601      601           
=======================================
+ Hits         3630     3631    +1     
  Misses         16       16           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Android devices freezes totally when trying to change value of a SingleSelectComponent. Add a short timeout to prevent infinite loop after calling onChange.
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my phone's Chrome using One UI 6 and Android 14

@jorilindell jorilindell merged commit 29673e8 into main Jan 18, 2024
2 of 4 checks passed
@jorilindell jorilindell deleted the fix/LINK-1853 branch January 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants