Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINK-1454 | Select price group for a signup #124

Merged
merged 1 commit into from
Jan 31, 2024
Merged

LINK-1454 | Select price group for a signup #124

merged 1 commit into from
Jan 31, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Jan 15, 2024 •
edited by jira bot
Loading

Description

Select price group for a signup

Closes

LINK-1454

@jorilindell jorilindell force-pushed the feature/LINK-1454-select-price-category branch from 010804e to 4524cc5 Compare January 16, 2024 08:59
@jorilindell jorilindell marked this pull request as ready for review January 16, 2024 12:16
@jorilindell jorilindell requested review from harriris-vincit and a team January 16, 2024 12:16
@jorilindell jorilindell force-pushed the feature/LINK-1454-select-price-category branch 3 times, most recently from 24558ad to e28b0af Compare January 24, 2024 09:50
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c05cc2a) 99.53% compared to head (590db46) 99.49%.

Files Patch % Lines
src/domain/signup/utils.ts 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   99.53%   99.49%   -0.05%     
==========================================
  Files         189      193       +4     
  Lines        3672     3750      +78     
  Branches      607      635      +28     
==========================================
+ Hits         3655     3731      +76     
- Misses         16       17       +1     
- Partials        1        2       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorilindell jorilindell force-pushed the feature/LINK-1454-select-price-category branch 4 times, most recently from 7006f44 to 0756559 Compare January 24, 2024 13:08
harriris-vincit
harriris-vincit approved these changes Jan 31, 2024
View reviewed changes
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the English and Swedish terms for price group / "Asiakasryhmä", but otherwise look good.

@jorilindell jorilindell force-pushed the feature/LINK-1454-select-price-category branch from 0756559 to 590db46 Compare January 31, 2024 14:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
98.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jorilindell jorilindell merged commit 345d372 into main Jan 31, 2024
5 checks passed
@jorilindell jorilindell deleted the feature/LINK-1454-select-price-category branch January 31, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harriris-vincit harriris-vincit harriris-vincit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorilindell @codecov-commenter @harriris-vincit