-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LINK-1858 | authenticate with access code #130
Conversation
009c3d8
to
aec739c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 193 194 +1
Lines 3802 3819 +17
Branches 648 653 +5
=======================================
+ Hits 3783 3800 +17
Misses 17 17
Partials 2 2 ☔ View full report in Codecov by Sentry. |
5c9cbbb
to
33bd287
Compare
Seems to be out-dated compared to the back-end changes: back-end now expects to use the one-time code when the user first does a GET request for a signup or group with the access_code parameter. After that, user linking is used instead of the parameter. |
33bd287
to
faac8b3
Compare
Very true. Removed the access code from the mutation queries. |
} from '../utils'; | ||
|
||
describe('canEditSignup function', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe('canEditSignup function', () => { | |
describe('canEditSignupGroup function', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good IMHO. Left a minor suggestion regarding suite description.
faac8b3
to
a15d79a
Compare
Makes it possible for strongly identified contact persons to get their own signups and signup groups. In API side retrieve action are permitted if the contact person's access code and email match the email of signup's or signup group's contact person.
a15d79a
to
991d32a
Compare
|
Description
Makes it possible for strongly identified contact persons to read, update and delete their own signups and signup groups. In API side these actions are permitted if the contact person's access code and email match those of the signup's or signup group's contact person.
Closes
LINK-1858