Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1858 | authenticate with access code #130

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Jan 26, 2024

Description

Makes it possible for strongly identified contact persons to read, update and delete their own signups and signup groups. In API side these actions are permitted if the contact person's access code and email match those of the signup's or signup group's contact person.

Closes

LINK-1858

@jorilindell jorilindell force-pushed the feature/LINK-1858-signup-with-access-code branch from 009c3d8 to aec739c Compare January 26, 2024 13:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (813d061) 99.50% compared to head (faac8b3) 99.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files         193      194    +1     
  Lines        3802     3819   +17     
  Branches      648      653    +5     
=======================================
+ Hits         3783     3800   +17     
  Misses         17       17           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorilindell jorilindell force-pushed the feature/LINK-1858-signup-with-access-code branch 2 times, most recently from 5c9cbbb to 33bd287 Compare January 26, 2024 15:42
@harriris-vincit
Copy link

Seems to be out-dated compared to the back-end changes: back-end now expects to use the one-time code when the user first does a GET request for a signup or group with the access_code parameter. After that, user linking is used instead of the parameter.

@jorilindell jorilindell force-pushed the feature/LINK-1858-signup-with-access-code branch from 33bd287 to faac8b3 Compare February 1, 2024 11:21
@jorilindell
Copy link
Contributor Author

Seems to be out-dated compared to the back-end changes: back-end now expects to use the one-time code when the user first does a GET request for a signup or group with the access_code parameter. After that, user linking is used instead of the parameter.

Very true. Removed the access code from the mutation queries.

@jorilindell jorilindell requested review from harriris-vincit and a team February 1, 2024 11:53
} from '../utils';

describe('canEditSignup function', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe('canEditSignup function', () => {
describe('canEditSignupGroup function', () => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good IMHO. Left a minor suggestion regarding suite description.

@jorilindell jorilindell force-pushed the feature/LINK-1858-signup-with-access-code branch from faac8b3 to a15d79a Compare February 2, 2024 13:54
Makes it possible for strongly identified contact persons to get their own signups and signup groups. In API side retrieve action are permitted if the contact person's access code and email match the email of signup's or signup group's contact person.
@jorilindell jorilindell force-pushed the feature/LINK-1858-signup-with-access-code branch from a15d79a to 991d32a Compare February 2, 2024 13:55
Copy link

sonarcloud bot commented Feb 2, 2024

@jorilindell jorilindell merged commit 0256a60 into main Feb 2, 2024
5 checks passed
@jorilindell jorilindell deleted the feature/LINK-1858-signup-with-access-code branch February 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants