Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1862 | add signup phone number to table #132

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Jan 31, 2024

Description

At the moment signups table displays only contact person's email and phone number. Add also signup's phone number to the table and rename columns of contact person's email and phone number

Closes

LINK-1862

Screenshot

Screenshot 2024-01-31 at 13 21 01

@jorilindell jorilindell requested review from harriris-vincit and a team January 31, 2024 11:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (813d061) 99.50% compared to head (9256f63) 99.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files         193      193           
  Lines        3802     3811    +9     
  Branches      648      650    +2     
=======================================
+ Hits         3783     3792    +9     
  Misses         17       17           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍 fix the code coverage though. (and some conflict)

At the moment signups table displays only contact person's email and phone number. Add also signup's phone number to the table and rename columns of contact person's email and phone number
@jorilindell jorilindell force-pushed the feature/LINK-1862_signup-phone-number branch from b8a5182 to 9256f63 Compare February 1, 2024 12:17
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jorilindell jorilindell merged commit 34f2d05 into main Feb 1, 2024
5 checks passed
@jorilindell jorilindell deleted the feature/LINK-1862_signup-phone-number branch February 1, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants