Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace undefined with null in user data #155

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented May 20, 2024

Description

Having undefined values in user data causes server errors when trying to serialise it. Fix the issue by replacing undefined values with null.
getSession function was executed every second in ReservationTimer component. Fix this by removing getSession function call from useEffect

@jorilindell jorilindell requested review from harriris-vincit and a team May 20, 2024 09:16
@terovirtanen
Copy link
Contributor

LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr155-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedregistrations-pr155-ui.dev.hel.ninja 😆🎉🎉🎉

Having undefined values in user data causes server errors.
Fix the issue by replacing undefined values with null.
@jorilindell jorilindell force-pushed the fix/replace-undefined-with-null branch from 28a5eb6 to 7c77fbc Compare May 20, 2024 13:38
@jorilindell jorilindell force-pushed the fix/replace-undefined-with-null branch from 7c77fbc to d3ab161 Compare May 20, 2024 13:42
Copy link

sonarcloud bot commented May 20, 2024

@terovirtanen
Copy link
Contributor

LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr155-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedregistrations-pr155-ui.dev.hel.ninja 😆🎉🎉🎉

Copy link

@arpargo arpargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorilindell jorilindell merged commit 0790f15 into main Jun 12, 2024
20 checks passed
@jorilindell jorilindell deleted the fix/replace-undefined-with-null branch June 12, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants