LINK-2104 | Prevent to delete signup after event start_time #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr168-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedregistrations-pr168-ui.dev.hel.ninja 😆🎉🎉🎉 |
jorilindell
force-pushed
the
feature/LINK-2104
branch
4 times, most recently
from
ae0c257
to
d582a3d
Compare
|
LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr168-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedregistrations-pr168-ui.dev.hel.ninja 😆🎉🎉🎉 |
public/locales/en/signup.json
Outdated
| "closedWithEnrolmentTime": "Registration for this event opens on {{openingDate}} at {{openingTime}}." | ||
| "closedWithEnrolmentTime": "Registration for this event opens on {{openingDate}} at {{openingTime}}.", | ||
| "eventStarted": "The event has already started and registration cannot be cancelled.", | ||
| "hasPaymentCancellation": "The payment will be cancelled and cannot be modified.", |
There was a problem hiding this comment.
Suggested change
| "hasPaymentCancellation": "The payment will be cancelled and cannot be modified.", | |
| "hasPaymentCancellation": "The payment is being cancelled and cannot be modified.", |
Present tense could be used here like in the Finnish sentence.
public/locales/en/signup.json
Outdated
| "closedWithEnrolmentTime": "Registration for this event opens on {{openingDate}} at {{openingTime}}.", | ||
| "eventStarted": "The event has already started and registration cannot be cancelled.", | ||
| "hasPaymentCancellation": "The payment will be cancelled and cannot be modified.", | ||
| "hasPaymentRefund": "The payment will be refunded and cannot be modified.", |
There was a problem hiding this comment.
Suggested change
| "hasPaymentRefund": "The payment will be refunded and cannot be modified.", | |
| "hasPaymentRefund": "The payment is being refunded and cannot be modified.", |
public/locales/sv/signup.json
Outdated
| "closedWithEnrolmentTime": "Anmälan till detta evenemang öppnar den {{openingDate}} kl {{openingTime}}." | ||
| "closedWithEnrolmentTime": "Anmälan till detta evenemang öppnar den {{openingDate}} kl {{openingTime}}.", | ||
| "eventStarted": "Evenemanget har redan börjat och registreringen kan inte avbrytas.", | ||
| "hasPaymentCancellation": "Registreringsavgiften kommer att annulleras och kan inte ändras.", |
There was a problem hiding this comment.
Suggested change
| "hasPaymentCancellation": "Registreringsavgiften kommer att annulleras och kan inte ändras.", | |
| "hasPaymentCancellation": "Anmälningsavgiften annulleras och kan inte ändras.", |
Present tense form according to ChatGPT.
public/locales/sv/signup.json
Outdated
| "closedWithEnrolmentTime": "Anmälan till detta evenemang öppnar den {{openingDate}} kl {{openingTime}}.", | ||
| "eventStarted": "Evenemanget har redan börjat och registreringen kan inte avbrytas.", | ||
| "hasPaymentCancellation": "Registreringsavgiften kommer att annulleras och kan inte ändras.", | ||
| "hasPaymentRefund": "Anmälningsavgiften kommer att återbetalas och kan inte ändras.", |
There was a problem hiding this comment.
Suggested change
| "hasPaymentRefund": "Anmälningsavgiften kommer att återbetalas och kan inte ändras.", | |
| "hasPaymentRefund": "Anmälningsavgiften återbetalas och kan inte ändras.", |
harriris-vincit
approved these changes
Jun 27, 2024
jorilindell
force-pushed
the
feature/LINK-2104
branch
from
d582a3d
to
fc429e9
Compare
|
|
LINKEDREGISTRATIONS-UI branch is deployed to platta: https://linkedregistrations-pr168-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedregistrations-pr168-ui.dev.hel.ninja 😆🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent to delete a signup or a signup group after an event has started.
Closes
LINK-2104