Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1674 | Save user_consent via API #98

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Oct 31, 2023

Description

Save user consent via API when creating a new signup group
Show user consent checkbox also if editing a signup group and any of user_consent is false

Closes

LINK-1674

@jorilindell jorilindell requested review from harriris-vincit and a team October 31, 2023 12:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #98 (33fee0f) into develop (5e797e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #98   +/-   ##
========================================
  Coverage    99.65%   99.65%           
========================================
  Files          154      154           
  Lines         2860     2861    +1     
  Branches       459      459           
========================================
+ Hits          2850     2851    +1     
  Misses          10       10           
Files Coverage Δ
src/domain/signup/utils.ts 100.00% <ø> (ø)
...in/signupGroup/signupGroupForm/SignupGroupForm.tsx 100.00% <100.00%> (ø)
src/domain/signupGroup/utils.ts 100.00% <100.00%> (ø)
src/domain/signupGroup/validation.ts 96.34% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jorilindell jorilindell changed the title Save user_consent via API LINK-1674 | Save user_consent via API Nov 1, 2023
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks superb IMO

@jorilindell jorilindell merged commit fe74d97 into main Nov 13, 2023
5 checks passed
@jorilindell jorilindell deleted the feature/LINK-1674-saving-user-consent branch November 13, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants