Make end user visible texts for login methods translatable #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #208 +/- ##
========================================
Coverage 78.06% 78.07%
========================================
Files 88 88
Lines 3679 3680 +1
========================================
+ Hits 2872 2873 +1
Misses 807 807
Continue to review full report at Codecov.
|
Changing an existing non-translated field to a translated one requires a multi-step process. The translated fields are first created with a different temporary name. Then data is copied from the non-translated fields to the translated fields. The old fields are removed and the translated fields are renamed to have the same name as the original fields had. All this resides in the single migration file in this commit. A few changes were required to an old migration file. 1) The bases needs to include TranslatableModelMixin in the migration where LoginMethod model is first introduced. This is required by Django-parler and how it works internally. django-parler/django-parler#263 (comment) 2) The non-null `name` field requires a default value so that migrating backwards works. The backward migration creates the non-null `name` column which fails unless the column also has a default value.
akikoskinen
force-pushed
the
HP-1195-translate-login-methods
branch
from
1d24dd4
to
01764db
Compare
akikoskinen
force-pushed
the
HP-1195-translate-login-methods
branch
from
01764db
to
80a122a
Compare
Good idea. Did that. |
|
Kudos, SonarCloud Quality Gate passed!
|
mikkokeskinen
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django-parler has this documentation for turning a previously non-translated field into a translated one. The problem with that document is, in reality it doesn't work like that.
See commit messages for details how it was solved.