feat: implement the existing alteration list and alteration deletion for the applicant (HL-1154) #2925
Conversation
EmiliaMakelaVincit
force-pushed
the
HL-1154-submitted-alteration-list
branch
from
4326474
to
308815f
Compare
|
API branch is deployed to platta: https://kesaseteli-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
API branch is deployed to platta: https://tet-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
ADMIN branch is deployed to platta: https://tet-admin-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
API branch is deployed to platta: https://helsinkilisa-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
TestCafe result is success for https://tet-admin-ui-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-employer-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2925.dev.hel.ninja 😿💢💥💥 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
YOUTH branch is deployed to platta: https://tet-youth-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://tet-youth-ui-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-youth-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2925.dev.hel.ninja 😿💢💥💥 |
| if company != alteration.application.company: | ||
| raise PermissionDenied(_("You are not allowed to do this action")) | ||
|
|
||
| if request.user.is_handler(): |
There was a problem hiding this comment.
You can use rest framework's permission_classes = [BFIsHandler] on the viewset level. Or is the API shared with applicant?
There was a problem hiding this comment.
Sorry vice versa so BFIsApplicant in this case.
There was a problem hiding this comment.
I'd say if they're shared, or plan to share then decouple as applicant and handler viewset. Otherwise role checking becomes swiss cheese if permission_class is not used.
There was a problem hiding this comment.
Both currently use the same API, yeah. Splitting doesn't sound like a bad idea, so I should do that – I'll do so in the following PRs during the handler side implementation. I'll have to take a closer look at the application list where that already exists but I imagine it should be pretty straightforward.
| @@ -48,6 +50,16 @@ const DecisionSummary = ({ application }: Props): JSX.Element => { | |||
| alteration.alterationType === ALTERATION_TYPE.TERMINATION | |||
| ); | |||
|
|
|||
| const sortedAlterations = application.alterations?.sort((a, b) => { | |||
There was a problem hiding this comment.
return new Date(a.endDate) - new Date(b.endDate) is enough in JS 😉
There was a problem hiding this comment.
Ah, right, that's true. I'll simplify it to that.
|
API branch is deployed to platta: https://kesaseteli-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
API branch is deployed to platta: https://tet-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
ADMIN branch is deployed to platta: https://tet-admin-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe admin result is failed for https://tet-admin-ui-pr2925.dev.hel.ninja 😿💢💥💥 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
API branch is deployed to platta: https://helsinkilisa-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
|
|
|
|
|
|
API branch is deployed to platta: https://kesaseteli-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
|
API branch is deployed to platta: https://tet-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
|
|
ADMIN branch is deployed to platta: https://tet-admin-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
|
API branch is deployed to platta: https://helsinkilisa-pr2925.api.dev.hel.ninja/healthz 🚀🚀🚀 |
TestCafe result is success for https://tet-admin-ui-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-employer-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
YOUTH branch is deployed to platta: https://tet-youth-ui-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://tet-youth-ui-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
|
YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2925.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-youth-pr2925.dev.hel.ninja 😆🎉🎉🎉 |
Additional notes 🗒️
In this PR, the DELETE REST endpoint is restricted for the use of the applicant only. It will be enabled for handlers later once the handler side progresses to that point.