-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement the existing alteration list and alteration deletion for the applicant (HL-1154) #2925
Merged
+794
−147
Merged
feat: implement the existing alteration list and alteration deletion for the applicant (HL-1154) #2925
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bce618e
feat: add list of existing alterations to the decision summary
EmiliaMakelaVincit 659abf0
feat: allow deletion of unopened applications for applicants in BE
EmiliaMakelaVincit d7f4ccc
fix: adjust alteration page styling
EmiliaMakelaVincit c75ee1a
fix: format fields for handled alteration
EmiliaMakelaVincit b5c7484
feat: add alteration deletion modal
EmiliaMakelaVincit a868f9e
fix: use correct comparison for dates with existing alterations
EmiliaMakelaVincit 42ab24a
chore: update alteration backend translations
EmiliaMakelaVincit 9014d37
chore: simplify alteration sorting
EmiliaMakelaVincit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use rest framework's
permission_classes = [BFIsHandler]
on the viewset level. Or is the API shared with applicant?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry vice versa so
BFIsApplicant
in this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say if they're shared, or plan to share then decouple as applicant and handler viewset. Otherwise role checking becomes swiss cheese if
permission_class
is not used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both currently use the same API, yeah. Splitting doesn't sound like a bad idea, so I should do that – I'll do so in the following PRs during the handler side implementation. I'll have to take a closer look at the application list where that already exists but I imagine it should be pretty straightforward.