Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-925: set CSRF header instantly when getting token #2261

Merged
merged 1 commit into from
Sep 13, 2023
Merged

HL-925: set CSRF header instantly when getting token #2261

merged 1 commit into from
Sep 13, 2023

Conversation

mjturt
Copy link
Collaborator

@mjturt mjturt commented Sep 6, 2023

Description ✨

Set axios instance CSRF header instantly when getting token from /me endpoint, as the axios instance might be initialized before there was CSRF token available.

@mjturt
fix: set CSRF header instantly when getting token
543260c 
Set axios instance CSRF header instantly when getting token from /me
endpoint as the axios instance might be initialized before there was
CSRF token available.
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

[yjdh] Please retry analysis of this Pull-Request directly on SonarCloud.

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2261.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2261.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2261.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2261.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.9% 86.9% Coverage
0.0% 0.0% Duplication

@sirtawast
Copy link
Collaborator

Ship it!

@mjturt mjturt merged commit 9d8009d into main Sep 13, 2023
53 checks passed
@mjturt mjturt deleted the hl-925 branch September 13, 2023 08:10
This was referenced Sep 13, 2023
Merged
Closed
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast sirtawast approved these changes

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjturt @terovirtanen @sirtawast