-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(handler): add error validation logic and toast for de minimis aid form (HL-1202) #2933
Conversation
Quality Gate passed for 'yjdh'Issues Measures |
Quality Gate passed for 'yjdh'Issues Measures |
Quality Gate passed for 'yjdh'Issues Measures |
Quality Gate passed for 'yjdh'Issues Measures |
API branch is deployed to platta: https://helsinkilisa-pr2933.api.dev.hel.ninja/healthz 🚀🚀🚀 |
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2933.dev.hel.ninja 🚀🚀🚀 |
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2933.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr2933.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr2933.dev.hel.ninja 😆🎉🎉🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks, can be merged without another review after possible fixes.
@@ -336,6 +336,10 @@ | |||
"label": "Enimmäismäärä ylitetty", | |||
"content": "De minimis-tuen enimmäismäärä on ylitetty. Tuki voi olla enintään {{amount}} euroa, joka myönnetään yritykselle kuluvan vuoden ja kahden edellisen verovuoden kuluessa. Enimmäismäärässä huomioidaan kaikkien eri viranomaisten kyseisenä ajanjaksona de minimis -tukena myöntämä rahoitus." | |||
}, | |||
"deMinimisUnfinished": { | |||
"label": "Puuttuvia de minimis -tuen tietoja", | |||
"content": "Täytä puuttuvat minimis -kentät ja paina 'Lisää' painiketta." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 'Lisää' painiketta -> Lisää-painiketta / 'Lisää'-painiketta
- minimis -kentät -> de minimis -kentät
if (isFormInputIncomplete()) { | ||
setUnfinishedDeMinimisAidRow(true); | ||
} else { | ||
setUnfinishedDeMinimisAidRow(false); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This effectively just equals to setUnfinishedDeMinimisAidRow(isFormInputIncomplete())
, the if-else is redundant.
Description ✨
Add validation for handler's de minimis form when creating a new application.