Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(handler): add error validation logic and toast for de minimis aid form (HL-1202) #2933

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

sirtawast
Copy link
Collaborator

Description ✨

Add validation for handler's de minimis form when creating a new application.

@sirtawast sirtawast changed the title Hl 1202 feat(handler): add error validation logic and toast for de minimis aid form Apr 16, 2024
@sirtawast sirtawast changed the title feat(handler): add error validation logic and toast for de minimis aid form feat(handler): add error validation logic and toast for de minimis aid form (HL-1202) Apr 16, 2024
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
26 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 16, 2024

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2933.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2933.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2933.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2933.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2933.dev.hel.ninja 😆🎉🎉🎉

Copy link
Collaborator

@EmiliaMakelaVincit EmiliaMakelaVincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, can be merged without another review after possible fixes.

@@ -336,6 +336,10 @@
"label": "Enimmäismäärä ylitetty",
"content": "De minimis-tuen enimmäismäärä on ylitetty. Tuki voi olla enintään {{amount}} euroa, joka myönnetään yritykselle kuluvan vuoden ja kahden edellisen verovuoden kuluessa. Enimmäismäärässä huomioidaan kaikkien eri viranomaisten kyseisenä ajanjaksona de minimis -tukena myöntämä rahoitus."
},
"deMinimisUnfinished": {
"label": "Puuttuvia de minimis -tuen tietoja",
"content": "Täytä puuttuvat minimis -kentät ja paina 'Lisää' painiketta."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 'Lisää' painiketta -> Lisää-painiketta / 'Lisää'-painiketta
  • minimis -kentät -> de minimis -kentät

Comment on lines +63 to +67
if (isFormInputIncomplete()) {
setUnfinishedDeMinimisAidRow(true);
} else {
setUnfinishedDeMinimisAidRow(false);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively just equals to setUnfinishedDeMinimisAidRow(isFormInputIncomplete()), the if-else is redundant.

@sirtawast sirtawast merged commit 752d9eb into main Apr 24, 2024
66 checks passed
@sirtawast sirtawast deleted the hl-1202 branch April 24, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants