Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hl 1356 automation fix #3083

Merged
merged 5 commits into from
Jun 14, 2024
Merged

fix: Hl 1356 automation fix #3083

merged 5 commits into from
Jun 14, 2024

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented Jun 11, 2024

Description ✨

HL-1356

When the old way of processing applications in the handler app was used along with the new Ahjo automation, the applications that were meant to be handled without the automation and a single application batch were being automated and assigned a single application batch nevertheless.
This PR adds a new handled_by_ahjo_automation attribute for Application which is set to True when an application is taken in to handling status by a handler and they have toggled the new Ahjo features on in the header. The handled_by_ahjo_automation is then used to filter out the applications that are not to be automated before sending any Ahjo requests.

Issues πŸ›

Testing βš—οΈ

Screenshots πŸ“Έ

Additional notes πŸ—’οΈ

@rikuke rikuke requested review from sirtawast and EmiliaMakelaVincit and removed request for sirtawast June 11, 2024 11:58
@rikuke rikuke force-pushed the HL-1356-automation-fix branch 2 times, most recently from 70bc649 to 988e6b7 Compare June 12, 2024 09:55
@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3083.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3083.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3083.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@rikuke rikuke force-pushed the HL-1356-automation-fix branch 2 times, most recently from 52d2b79 to c9ebfa2 Compare June 13, 2024 09:40
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3083.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3083.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3083.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
47 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
40 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 14, 2024

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3083.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3083.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3083.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3083.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@rikuke rikuke merged commit 198b077 into main Jun 14, 2024
65 checks passed
@rikuke rikuke deleted the HL-1356-automation-fix branch June 14, 2024 11:40
@rikuke rikuke changed the title Hl 1356 automation fix fix: Hl 1356 automation fix Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants