fix: Hl 1361 missing full application #3089
Conversation
| @@ -272,7 +272,9 @@ def prepare_update_application_payload( | |||
| """Prepare the payload that is sent to Ahjo when an application is updated, \ | |||
| in this case it only contains a Records dict""" | |||
| if not pdf_summary.ahjo_version_series_id: | |||
| raise ValueError("Attachment must have an ahjo_version_series_id for update.") | |||
| raise ValueError( | |||
| f"Attachment for {application.application_number} must have a ahjo_version_series_id for update." | |||
There was a problem hiding this comment.
While not related to this issue, having this helps debug update request to hyte more efficiently.
| @@ -716,6 +716,30 @@ def test_generate_ahjo_secret_decision_text_xml(decided_application): | |||
| os.remove(attachment.attachment_file.path) | |||
|
|
|||
|
|
|||
| @pytest.mark.django_db | |||
| def test_get_applications_for_ahjo_update( | |||
There was a problem hiding this comment.
Test that update request gets the right amount of applications.
|
|
|
|
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3089.dev.hel.ninja 🚀🚀🚀 |
|
API branch is deployed to platta: https://helsinkilisa-pr3089.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3089.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3089.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-pr3089.dev.hel.ninja 😆🎉🎉🎉 |
rikuke
changed the title
Description ✨
HL-1361
This time ensure, that the full application attachment is included in the pre fetch query, where it was not previously included.
Issues 🐛
Testing ⚗️
Screenshots 📸
Additional notes 🗒️