feat: improve on table listings (HL-1325) #3119
Conversation
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3119.dev.hel.ninja 🚀🚀🚀 |
|
API branch is deployed to platta: https://helsinkilisa-pr3119.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3119.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3119.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3119.dev.hel.ninja 😆🎉🎉🎉 |
|
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3119.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3119.dev.hel.ninja 🚀🚀🚀 |
|
API branch is deployed to platta: https://helsinkilisa-pr3119.api.dev.hel.ninja/healthz 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3119.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3119.dev.hel.ninja 😆🎉🎉🎉 |
|
|
|
| const dateForAdditionalInformationNeededBy = ( | ||
| dateString: string | Date | ||
| ): string => ` ${String(dateString).replace(/\d{4}$/, '')}`; | ||
|
|
There was a problem hiding this comment.
I'm not sure if, regardless of ApplicationListTableTransform's typing, there's any situation where a Date object can end up here. But assuming there is, I don't think you can avoid the convertToUIDateFormat call here, as String(new Date()).replace(/\d{4}$/, '') is locale dependant and for example on UK English locale this returns the painfully long 'Wed Jun 26 2024 16:44:57 GMT+0300 (Eastern European Summer Time)'.
| ([ | ||
| APPLICATION_STATUSES.HANDLING, | ||
| APPLICATION_STATUSES.INFO_REQUIRED, | ||
| ].includes(application.status) && | ||
| isNewAhjoMode && | ||
| application.handledByAhjoAutomation) || | ||
| ([ | ||
| APPLICATION_STATUSES.ACCEPTED, | ||
| APPLICATION_STATUSES.REJECTED, | ||
| ].includes(application.status) && | ||
| isNewAhjoMode && | ||
| application.handledByAhjoAutomation) || | ||
| ([ |
There was a problem hiding this comment.
I think these two can be combined together at least to make this huge effective one-liner a bit less wieldy. Could consider just abandoning the idea of combining this all into one statement and using a function with actual if-else structure, too.
Description ✨
Various small fixes and improvements to help handler on their daily duties. Also fixes some of the issues with listing applicants in new vs. old ahjo mode.