Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove irrelevant fields from decision box etc. (HL-1332, HL-1371, HL-1380) #3123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EmiliaMakelaVincit
Copy link
Collaborator

Additional notes πŸ—’οΈ

This removes all fields related to monetary matters from the decision box for applications that are rejected, cancelled, or waiting for input from the applicant. It also changes the default visibility of the decision box to be shown for cancelled and rejected applications (first of which should rarely if ever have an Ahjo case ID in a real world scenario), and adds translation strings for an application that's waiting for additional details (in this case the Ahjo case ID should be present for the box to be shown).

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-employer-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-youth-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@EmiliaMakelaVincit EmiliaMakelaVincit changed the title fix: remove irrelevant fields from decision box etc. (HL-1332, HL-1380) fix: remove irrelevant fields from decision box etc. (HL-1332, HL-1371, HL-1380) Jun 27, 2024
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
8.8% Coverage on New Code (required β‰₯ 65%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
33.3% Coverage on New Code (required β‰₯ 65%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

sonarcloud bot commented Jun 28, 2024

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-employer-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3123.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr3123.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-youth-pr3123.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants