fix: cross-browser image sizing

CityOfDetroit · Sep 14, 2022 · 29df631 · 29df631
1 parent ea32152
commit 29df631
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/ui-components/src/blocks/ImageCard.scss b/ui-components/src/blocks/ImageCard.scss
@@ -25,7 +25,7 @@
 
   img {
     border-radius: var(--border-radius);
-    width: 100%;
+    aspect-ratio: 16 / 9;
     height: var(--image-height);
     object-fit: cover;
   }
@@ -58,7 +58,7 @@
     }
 
     img {
-      aspect-ratio: 16 / 9;
+      width: 100%;
       display: block;
 
       &:nth-child(1) {

diff --git a/ui-components/src/overlays/Overlay.tsx b/ui-components/src/overlays/Overlay.tsx
@@ -67,18 +67,6 @@ export const Overlay = (props: OverlayProps) => {
     }
   }, [elForPortal, overlayRoot])
 
-  // // disable body scrolling when the overlay is open
-  // useEffect(() => {
-  //   if (props.scrollable) return
-  //   if (!(overlayRoot && elForPortal)) return
-
-  //   props.open ? disableBodyScroll(elForPortal) : enableBodyScroll(elForPortal)
-
-  //   return () => {
-  //     enableBodyScroll(elForPortal)
-  //   }
-  // }, [elForPortal, overlayRoot, props.open])
-
   return (
     elForPortal &&
     createPortal(