Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Memory Improvements to Listing Exports #1602

Closed
ColinBuyck opened this issue Mar 23, 2023 · 1 comment
Closed

[Bug] Memory Improvements to Listing Exports #1602

ColinBuyck opened this issue Mar 23, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ColinBuyck
Copy link
Collaborator

ColinBuyck commented Mar 23, 2023

The formatting done in the listings-csv-exporter.service.ts demonstrates that significantly more data is being pulled in than is necessary for the export output. The clearest known example is in the use of addUnitSummariesToListings in. While it does provide needed formatting for rent ranges, it stores unneeded ranges of square footage, floor, and bathrooms. Additionally, it stores duplicate AMI chart names when only unique values are needed. This memory waste has the potential to create issues down the road as more listings are added to Detroit.

This ticket is to reduce memory usage in the listings export flow, starting with the use of addUnitSummariesToListings and then exploring other potential optimizations. Note: the addUnitSummariesToListings function is used in other contexts so if making direct changes to the function (as opposed to creating a new one), ensure there are no unintended impacts.

QA Notes: https://detroit-partners-dev.netlify.app/sign-in

  1. Sign in
  2. Click export to CSV
  3. Ensure the data and particularly units data is still present, accurate, and formatted correctly
@ColinBuyck ColinBuyck added the bug Something isn't working label Mar 23, 2023
@github-actions github-actions bot added this to Needs triage in Backlog-Sprint Mar 23, 2023
@github-actions github-actions bot added this to Triage in Milestones Mar 23, 2023
@sarahlazarich
Copy link
Collaborator

lgtm!

Backlog-Sprint automation moved this from Needs triage to Closed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants