build: updates ts-node version (#2757) #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
YazeedLoonat
approved these changes
Jul 20, 2022
| @@ -457,7 +457,7 @@ describe("Applications", () => { | |||
| await supertest(app.getHttpServer()) | |||
| .get(`/applications/${createRes.body.id}`) | |||
| .set(...setAuthorization(user1AccessToken)) | |||
| .expect(404) | |||
| .expect(500) | |||
There was a problem hiding this comment.
Just curious why this changed here
There was a problem hiding this comment.
This change was also done in core, and we should look into why this changed there. I'll create an issue off of this.
emilyjablonski
approved these changes
Jul 20, 2022
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings over a fix from core which updates the ts-node version