Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter code to include upstream changes, fix filter property type #180

Merged
merged 16 commits into from
Jul 16, 2021

Conversation

avaleske
Copy link

@avaleske avaleske commented Jul 13, 2021

Issue #143

Merge in upstream changes to filters.

Addresses #143

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Merges in changes to upstream filters. See https://github.com/bloom-housing/bloom/pull/1359/files for changed filed.

  • Adds generic filters query param to listings.controller.ts
  • Adds generic filters handling to listings.service.ts
  • Adds an enum of filter types to listing.dto.ts, so we can handle specific filters differently
  • Changes upstream filter param from ListingFilterParam[] to ListingFilterParam to match its actual type.

I opened issues to for some TODOs in this PR:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Test with paths like

  • /listings?filter[$comparison]=<>&filter[neighborhood]=Foster%20City
  • /listings?filter[$comparison]=<>&filter[name]=colesium&filter[$comparison]==&filter[neighborhood]=Foster%20City

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@avaleske avaleske linked an issue Jul 13, 2021 that may be closed by this pull request
@avaleske avaleske changed the title Draft. Update filter code to include upstream changes Update filter code to include upstream changes, fix filter property type Jul 16, 2021
@avaleske avaleske requested a review from elenm July 16, 2021 22:09
@avaleske avaleske marked this pull request as ready for review July 16, 2021 22:10
@avaleske avaleske merged commit eaf25fd into main Jul 16, 2021
@avaleske avaleske deleted the feature/avaleske-align-filters-with-upstream branch July 16, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update backend to match upstream changes
3 participants