Fix MFA Bugs and Update .env Variables #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelbcastillo
requested changes
Jan 22, 2021
.env.example
Outdated
| @@ -59,6 +59,9 @@ ELASTICSEARCH_VERIFY_CERTS=FALSE | |||
| REDIS_HOST=<REDIS HOSTNAME> | |||
| REDIS_PORT=<REDIS PORT> | |||
|
|
|||
| # Celery | |||
| CELERY_CLEAR_EXPIRED_SESSION_IDS=<CELERY_CLEAR_EXPIRED_SESSION_IDS> | |||
There was a problem hiding this comment.
Can we change this variable name to be something like CELERY_CLEAR_EXPIRED_SESSION_IDS_INTERVAL that way we know exactly what it refers to?
app/celery_config.py
Outdated
|
|
||
| CELERY_IMPORTS = ['app.jobs'] | ||
| CELERY_TASK_RESULT_EXPIRES = 30 | ||
| CELERY_TIMEZONE = 'EST' | ||
| CELERY_CLEAR_EXPIRED_SESSION_IDS = os.environ.get('CELERY_CLEAR_EXPIRED_SESSION_IDS') |
There was a problem hiding this comment.
Should we have a default here (e.g. 0)?
joelbcastillo
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.