Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to react, first round #11

Merged
merged 6 commits into from
Dec 17, 2017
Merged

Move to react, first round #11

merged 6 commits into from
Dec 17, 2017

Conversation

slipo
Copy link
Collaborator

@slipo slipo commented Dec 16, 2017

Here's the first round of migrating to (P)React. This turned out to be a lot of work and I want to get this out for review and start doing smaller PRs.

Some things this gives us:

  • Almost all features that are working already in master
  • Preact (Migrate to React #9)
  • A foundation in React to work with for the next release. We have a bunch of tasks and this provides something for multiple people to build on.
  • Uses neon-js 2.2.1 from CoZ repo (Use CoZ official repo for neon-js #6)
  • babel formating rules
  • Redux for storing state
  • preact-material-components as requested by @deanpress

Things to improve:

  • Styling. It wasn't straightforward to map the styling over from the old way. I'm hoping @deanpress will take a pass at bringing his previous work over.
  • Perhaps restructure the directories/files a bit
  • Messages bring the popup up, but it doesn't show the authorize dialog yet. I think we should consider changing this dialog anyways because it should say where your coins are going and how much
  • Send Invoke forms are hooked up but we need to integrate into neon-js to make it actually do something. Before we used a branch for this + Test Invoke. I figured out Test Invoke but we still need to figure out how to do the send preferably without forking neon-js.
  • Import/Create/Export wallet and Config weren't working for me in master and still don't work.
  • I'd like to improve the popup remembering things in between closing/opening, especially which route you were on and form values.

@slipo slipo changed the base branch from master to development December 16, 2017 16:59
@hal0x2328 hal0x2328 merged commit 60ec098 into CityOfZion:development Dec 17, 2017
@slipo slipo deleted the react branch December 17, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants