Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form hoc component #112

Merged
merged 19 commits into from
May 21, 2018
Merged

Form hoc component #112

merged 19 commits into from
May 21, 2018

Conversation

FredrikOseberg
Copy link

This pull requests introduces a higher order component that significantly reduces code duplication in regards to error messages and common form methods across multiple components. All form components that utilises the same error method handling are now wrapped in a higher order component that supplies the error messages and methods as props, resulting in significant reduction in code duplication. Tests have been amended as well in order to be relevant with the new change.

slipo and others added 19 commits March 11, 2018 11:20
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 40.632% when pulling 5a3b195 on FredrikOseberg:form-hoc-component into 4c41da8 on CityOfZion:development.

@uvmetal uvmetal merged commit d534d98 into CityOfZion:development May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants