forked from Splyse/NeoLink
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress larger render functions #113
Merged
uvmetal
merged 31 commits into
CityOfZion:development
from
FredrikOseberg:compress-larger-render-functions
May 21, 2018
Merged
Compress larger render functions #113
uvmetal
merged 31 commits into
CityOfZion:development
from
FredrikOseberg:compress-larger-render-functions
May 21, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto development
…nto development
…nto development
…nto development
…nto development
…nto development
…nto development
…rovement to code readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant structural changes to code. Complete refactor of form components and broke some big render functions into more digestible and readable pieces of code. Removed duplication of redux render component functions by adding them to the withForm higher order component, which will increase code maintainability.