Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS background bugfix - added repsonsiveness indications #116

Merged
merged 7 commits into from
Jun 4, 2018

Conversation

DalderupMaurice
Copy link

@DalderupMaurice DalderupMaurice commented May 26, 2018

Regular fixes

  • fixed css background bug on certain occasions
  • Changed cursor on amount values

Opinion needed - to keep or not to keep 😄

  • removed outlines on click
  • added some css animation to indicate responsiveness

Showcase:

UPDATED 29-05-2018

  • Added focus ring management
  • Updated CSS to be more consistent

Showcase:

@coveralls
Copy link

coveralls commented May 26, 2018

Coverage Status

Coverage decreased (-0.02%) to 41.086% when pulling 9e10e7a on DalderupMaurice:chore/css-fix into e1183d4 on CityOfZion:development.

@DalderupMaurice
Copy link
Author

DalderupMaurice commented May 26, 2018

Discussed with @FredrikOseberg
Might want to add in the outlines back for access ability reasons

I'd like to hear your opinions :) @slipo @phetter

Thought I'd quickly threw it in with the background issue as it's just a minor change.
If you guys would like to keep the outlines, I can change it back and keep the background css fix in + cursor adjustments ^^

We could also have a middle-way by just restyling the outlines, if we decide to keep them 😄

@FredrikOseberg
Copy link

https://a11yproject.com/posts/never-remove-css-outlines/

I don't think we should completely remove outlines, as it's relied upon by many visually impaired users worldwide. Open to consider restyling. Please refer to a11y project to make sure we keep compliant with access ability. As the importance of the internet increases, so does our responsibility to make sure anyone can use it :)

@DalderupMaurice
Copy link
Author

We might also consider what-input https://www.npmjs.com/package/what-input
This hides the outline for mouse only, not for keyboard @FredrikOseberg

@DalderupMaurice
Copy link
Author

DalderupMaurice commented May 29, 2018

What do you think? @FredrikOseberg
I've updated to see how'd it be with what-input

@uvmetal uvmetal merged commit 44c8ee8 into CityOfZion:development Jun 4, 2018
@DalderupMaurice DalderupMaurice deleted the chore/css-fix branch June 4, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants