Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to invoke with multiple arguments #122

Merged
merged 11 commits into from
Jun 19, 2018

Conversation

DalderupMaurice
Copy link

@DalderupMaurice DalderupMaurice commented Jun 13, 2018

Added variadic args for doInvoke and the proper parsing of each type of argument

Screenshot of invocation results as proof of work:

  • 1 Invocation with a test smart contract (first 2 shown in screenshot are "normal" ones :P )
  • 1 Invocation using CheckWitness with a test smart contract (The last one - parsing of address well done)

I am out after today until the end of the week
Things to do (I'll add these in as separate PR's as this is already a fully functioning piece)

  • Ability to pass a variable length of arguments through invocations by apps
  • Refactor @connect experimental annotations

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 40.741% when pulling 997ec25 on DalderupMaurice:development into 33ee2db on CityOfZion:development.

Copy link

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use buttons located in components/common/buttons. PrimaryButton and SecondaryButton components are made explicitly for NeoLink, and we are trying to move away from material library rmwc.

@DalderupMaurice
Copy link
Author

Thanks, I'll update it!
Copied it from testInvoke - I'll include these too :)

@uvmetal uvmetal merged commit 2e9e850 into CityOfZion:development Jun 19, 2018
@DalderupMaurice DalderupMaurice deleted the development branch June 19, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants