Tx Remarks #123
Closed
Tx Remarks #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge react version of app into master
Update example in README to sendeo
Add export wallet + README update into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Notes:
Some tests were fudged to get code into play so as not to hold up community PRs; will address in test sprint asap.
State tree for network switcher needs a looking at in another PR. This is open for grabs for anyone wanting to contribute or I will resolve soon. This works as-is.
Some of the neon-js code has been removed in favor of a local Neolink api file (NeoscanAPI.js) so as to ease integration and control api needs without need to interrupt or wait on neon-js. Once Neolink neoscan api needs freeze we will look at porting back to neon-js. This is another contribution opportunity.
Details Follow:
Supports Transaction Remarks
Transaction interface now supports remark attribute usage.
Supports Transaction Fees
Added optional parameter to sendAsset.
Private/Custom Network Support
Custom URL support has been added to allow connectivity with any host:port/api.
Promisified Neoscan Support API
Developed Custom Neolink interface to Neoscan and reworked DX.
Updated Network Switcher to Support Neoscan API
Neon-js / NeonDB is still present, but mostly, if not completely, inactive.
This was chosen as a result of time constraints around defusing API documentation difficulties.
Various Usability Features
Transaction Summary Info
Transaction Timestamps on Tx Cards
Debug Helpers
Deep Object Inspection & Logging
Fixed Private Key Storage
Promisified FQDN URL Validation for Custom Networks and Runtime Assurance
Added String Utilities
Rewrote tests to work with Neoscan