Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/NEP-5: List Tokens on Send Card #176

Merged
merged 13 commits into from Dec 12, 2018
Merged

Conversation

uvmetal
Copy link
Collaborator

@uvmetal uvmetal commented Dec 2, 2018

This PR is the ground work to enable NEP-5 transfer via primary wallet send card interface.

The format needs a designer's attention as I've only add the code structure to list assets at this point and the temporary appearance doesn't integrate with the layout so well, in my opinion.

The debugging code is temporary and will be addressed once final transfer code is completed.

Copy link

@DalderupMaurice DalderupMaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments below

src/app/containers/Asset/Asset.js Show resolved Hide resolved
src/app/containers/Asset/Asset.js Outdated Show resolved Hide resolved
src/app/containers/Asset/Asset.js Outdated Show resolved Hide resolved
src/app/utils/api/neoscan.js Outdated Show resolved Hide resolved
@DalderupMaurice
Copy link

Do you have a screenshot? I'd like to see the "design" to see if I could improve it or if we would need additional help from a designer

Copy link

@DalderupMaurice DalderupMaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the NetworkSwitcher.test.js.snap please, how does this persist with every PR?
It breaks the tests

@uvmetal uvmetal added this to In progress in Chrome Web Store RC1 via automation Dec 12, 2018
@uvmetal uvmetal merged commit cafebd8 into CityOfZion:development Dec 12, 2018
Chrome Web Store RC1 automation moved this from In progress to Done Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants