-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepush #54
Prepush #54
Conversation
…'t sneak in again.
package.json
Outdated
@@ -11,7 +11,8 @@ | |||
"lint": "eslint ./", | |||
"lintFix": "eslint ./ --fix", | |||
"start": "node utils/webserver.js", | |||
"test": "jest" | |||
"test": "jest", | |||
"prepush": "echo 'running lint...' && yarn lint && echo 'running tests...' && yarn test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're getting rid of yarn, this script should probably not use yarn.
@@ -45,6 +46,7 @@ | |||
"fs-extra": "^0.30.0", | |||
"html-loader": "^0.5.1", | |||
"html-webpack-plugin": "2.30.1", | |||
"husky": "^0.14.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this dependency used here?
Looks good to me, I don't have merge power though. |
Run tests + lint before allow a push to go through.
Takes care of: #46