Create account with encrypted key #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikOseberg
commented
Apr 15, 2018
FredrikOseberg
commented
- Add ability to create an account with existing encrypted key
- Add proper label validation
- Write tests for new account creation with WIF
FredrikOseberg
changed the title
|
I don't think we should remove adding an account with a WIF. This should just be additional functionality. |
|
That functionality is still there. It's just not on the front page anymore, because 3 options to create account and login is too much to clutter the front page. I added a second page that gathered all the options to create account. Create account with WIF is the third option :) |
|
lgtm. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.