This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Fixes known issues in the crowdsale demo #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… address format in nep5 functions
|
Looks like some of the tests are failing (like one due to the use of |
This was referenced Oct 6, 2018
|
Interested in getting feedback on this^ |
|
Looks good, thanks for the changes! I would only add that the demo is only for compiler testing purposes and shouldn't be confused for something that is a production ready NEP5 token. |
|
@localhuman is there an example of a place with a production ready NEP5 contract? The awesome-neo repo lists these contracts and the ICO-Templates repo is empty so far. Would it make sense to put some of this there? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Github does this address?
#98 #99
What problem does this PR solve?
Adds OnTransfer to the minting in the deploy function and fixes total supply. Also makes sure that the nep5 functions are checking that the arguments are in the right format
How did you solve this problem?
#98 and #99 are pretty self explanatory. Length check for addresses for the argument formatting issue
How did you make sure your solution works?
Standardized it with the standalone NEP5 demo and another contract that I've tested on my private net
Are there any special changes in the code that we should be aware of?
No
Is there anything else we should know?
The NEP5 demo has slightly different code than the one in the crowdsale demo. They should probably be fully standardized in the future