Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StackParam JSON Unmarshaler #116

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Add StackParam JSON Unmarshaler #116

merged 1 commit into from
Jan 22, 2019

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jan 18, 2019

Problem

It is very convenient when StackParam is correctly unmarshaled from JSON.

Solution

Implement custom UnmarshalJSON

im-kulikov
im-kulikov approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@im-kulikov im-kulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smile-3

@anthdm anthdm merged commit df2e9f6 into nspcc-dev:master Jan 22, 2019
@im-kulikov
Copy link
Contributor

@anthdm thx

@hal0x2328 hal0x2328 added the I1 High impact label Feb 7, 2019
@hal0x2328
Copy link
Contributor

Please reward fyrchik 300 points.

@lllwvlvwlll
Copy link

@fyrchik please provide a neo address for awards.

@lllwvlvwlll
Copy link

https://neoscan.io/transaction/2ce8e8bee250bf869670d40fe36d3cdba5a71da48f9c8dd777ac5734a921b8c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-kulikov im-kulikov im-kulikov approved these changes

Assignees
No one assigned
Labels
I1 High impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fyrchik @im-kulikov @hal0x2328 @lllwvlvwlll @anthdm