Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Display config DataDirectoryPath after app name in Title bar #38

Merged
9 commits merged into from Feb 19, 2018
Merged

Display config DataDirectoryPath after app name in Title bar #38

9 commits merged into from Feb 19, 2018

Conversation

mwherman2000
Copy link
Contributor

Display config DataDirectoryPath after app name in Title bar to indicate which set of JSON configuration files are being used.

In MainForm.cs, add the following single line of code to the end of the constructor:

this.Text += " - " + (String.IsNullOrEmpty(Settings.Default.DataDirectoryPath) ? "---" : Settings.Default.DataDirectoryPath);

Michael Herman (Lenovo) added 2 commits February 10, 2018 13:11
…ate which set of JSON configuration files are being used.
…t to support communications with the NEO privatenet Docker container (https://hub.docker.com/r/metachris/neo-privnet-with-gas/). The original (default) config.json and protocol.json remain unchanged.
@mwherman2000
Copy link
Contributor Author

Added a second set of changes to the fork: Added config.neodocker.json and protocol.neodocker.json to the project to support communications with the NEO privatenet Docker container (https://hub.docker.com/r/metachris/neo-privnet-with-gas/). The original (default) config.json and protocol.json remain unchanged.

…t to support communications with the NEO privatenet Docker container (https://hub.docker.com/r/metachris/neo-privnet-with-gas/). The original (default) config.json and protocol.json remain unchanged. Added enhanced log formatted "useSmartMessages"
@mwherman2000
Copy link
Contributor Author

Added a third set of changes to implement "smart message" formatting in the Event Log:

https://github.com/mwherman2000/neo-windocs/blob/master/windocs/windocs-presentations/images/Transactions2Log.png

Note the "smart messages" on the left side of the log. I add some heuristics to neo-gui-developer to format the messages based on what it thinks the array of bytes is supposed to represent it. It's kind of cool. No more "billions of bytes" with no obvious meaning.

The neo-gui event log now knows about account addresses, private keys, WIFs, public keys, etc. and produces smarter formatting of those values.

@igormcoelho
Copy link

This is a very nice contribution! Congratulations! Hope it gets accepted soon :)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR - i would suggest that you leave config.json and protocol.json still pointing at testnet rather than the docker config as setting up privnet requires another step by the user to make this app work

@mwherman2000
Copy link
Contributor Author

Added support for $FOO format specifiers in arg[0] of Runtime.Notify calls. Checkout https://github.com/mwherman2000/neo-windocs/blob/master/windocs/windocs-presentations/images/BlockTxNumbers1.png

@mwherman2000
Copy link
Contributor Author

@birmas, I didn't change the default config.json nor protocol.json. I'm only requested the addition of the 2 new privatenet versions of the file (with separate names).

...or did I by mistake send up a pair of changed config.json nor protocol.json files too?? ...it wasn't my intention. Let me know.

@mwherman2000
Copy link
Contributor Author

Remerged all of my changes

@mwherman2000
Copy link
Contributor Author

I think everything is synced up. Please accept these changes.

@ghost ghost merged commit 357efdd into CityOfZion:master Feb 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants