Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows portability #8

Closed
canesin opened this issue Mar 27, 2018 · 3 comments
Closed

Windows portability #8

canesin opened this issue Mar 27, 2018 · 3 comments
Assignees
@revett
Milestone
CLI

Comments

@canesin
Copy link

canesin commented Mar 27, 2018 •
edited
Loading

Unfortunately Makefiles are not easily supported in the platform 90% of the developers of the world use.
@metachris
Copy link
Contributor

Perhaps we should just show the 2 commands that are needed directly:

docker-compose up
docker exec -it neo-python np-prompt -p -v

Not sure we even need the wrapper/Makefile...

@revett
Copy link
Contributor

revett commented Mar 28, 2018

@canesin I am working on porting the contents of the Makefile to a cross-platform CLI. This will also allow us to unit test the project.

@revett revett self-assigned this Mar 28, 2018
@revett revett added this to the CLI milestone Mar 28, 2018
@revett revett mentioned this issue Mar 28, 2018
Merged
metachris added a commit that referenced this issue Apr 1, 2018
@metachris
Added docker commands to start and attach
097ae06 
Added the two Docker commands you need to use to start and attach to neo-python. It's important to document the raw usage without any wrappers.

Also, in the current state, the Makefile has several problems (see #3 #4 #5 #8) and is not generally recommendable.
@metachris metachris mentioned this issue Apr 1, 2018
Merged
metachris added a commit that referenced this issue Apr 1, 2018
@metachris
Added docker commands to start and attach (#10)
f9ac3a4 
* Added docker commands to start and attach

Added the two Docker commands you need to use to start and attach to neo-python. It's important to document the raw usage without any wrappers.

Also, in the current state, the Makefile has several problems (see #3 #4 #5 #8) and is not generally recommendable.

* README: fixed Docker link
@revett
Copy link
Contributor

revett commented May 14, 2018

Closing as solved by documentation that is now in README: https://github.com/CityOfZion/neo-local#windows-1

This will be improved in the future by the CLI, however I've seen Windows users run the project so I'm happy for the moment.

@revett revett closed this as completed May 14, 2018
@nunojusto nunojusto mentioned this issue Oct 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revett revett

Labels
None yet
Projects
None yet
Milestone
CLI
Development

No branches or pull requests
3 participants
@metachris @canesin @revett