Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements #110

Merged
merged 10 commits into from
Jan 8, 2020
Merged

Several improvements #110

merged 10 commits into from
Jan 8, 2020

Conversation

corollari
Copy link
Collaborator

@corollari corollari commented Jan 5, 2020

Improvements

  • Fix build process, it crashed beforehand
  • Added support for the websockets protocol
  • Added neologin nodes
  • Added missing flags (see message at the bottom)
  • Added CI/CD using Github Actions

HERE BE DEMONS

flag-hk.svg has been heavily edited manually because:

  1. Directly compiling the image gotten from flag-icon-css through gulp-svgmin results in it crashing
  2. I tracked the error to svgo, a dependency of gulp-svgmin and sent a PR to gulp-svgmin pinning a good version of that dep (dug through issues to find the reportedly good version, as it seems the bug has reappeared in new versions).
  3. Changed the dependencies of neo-mon to use that version. This resulted in the flag working properly but other flags breaking.
  4. Looked into the svgo crash and found that the error might be caused by an optimization that they applied to the css.
  5. Started digging through the git history to find a non-optimized version, managed to get it to not break but then the display was wrong.
  6. Edited the svg directly to try to fix the bug directly and I finally succeeded.
  7. Wrote this in the hope that someone stumbles into the same problem in the future ends up finding this comment through git blame, my hopes are not too high.

Extra

I'm willing to become the maintainer of this repo.

@fabwa fabwa merged commit d40cdb3 into CityOfZion:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants