Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Great Cleanup 馃Ы #113

Merged
merged 1 commit into from
Mar 12, 2020
Merged

The Great Cleanup 馃Ы #113

merged 1 commit into from
Mar 12, 2020

Conversation

corollari
Copy link
Collaborator

@corollari corollari commented Mar 12, 2020

Problem

The build system used in this repository suffers from bit-rot: it uses tools which have been deprecated and for which it's really hard to find documentation, most dependencies are not maintained and broken, the standards used are outdated and completely different from everything I've seen...

This results in a system which is really hard to maintain and build. As an example, when I started working with neo-mon it took me a whole day to get it to build and when preparing this PR I had a lot of problems finding documentation that was out-dated enough (in one instance I had to hunt down the correct version of the documentation of a package through git history and build it myself to see it). Furthermore, I have to be extremely cautious when modifying everything in order to avoid breaking anything.

Solution

This PRs solves that by simplifying the whole build process to the extreme, making it only depend on bash and npm (which installs only a single dependency!) and removing a lot of stuff which becomes unneeded.

Drawbacks

Because of the dependency on bash and several nix tools it will be much harder to build on Windows, nevertheless build.sh is easy to read and I believe it's still an improvement over the current build system.

It also removes the linters.

Extra

This PR also updates the CI action used for gh-pages deployment.

@fabwa fabwa merged commit fc3b92e into CityOfZion:master Mar 12, 2020
@corollari
Copy link
Collaborator Author

@fabwa That was fast 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants