Change BigInteger divisor operation to use floordiv rather than truediv

CityOfZion · Aug 23, 2018 · b537fc8 · b537fc8
1 parent f2ef604
commit b537fc8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -4,7 +4,7 @@ History
 
 0.5.1-dev (in progress)
 -----------------------
-* ...
+* Change BigInteger divisor operation to use floordiv rather than truediv
 
 
 0.5.0 (2018-08-21)

diff --git a/neocore/BigInteger.py b/neocore/BigInteger.py
@@ -51,7 +51,7 @@ def __floordiv__(self, *args, **kwargs):
         return BigInteger(super(BigInteger, self).__floordiv__(*args, **kwargs))
 
     def __truediv__(self, *args, **kwargs):  # real signature unknown
-        return BigInteger(super(BigInteger, self).__truediv__(*args, **kwargs))
+        return BigInteger(super(BigInteger, self).__floordiv__(*args, **kwargs))
 
 
 ZERO = BigInteger(0)

diff --git a/tests/test_numbers.py b/tests/test_numbers.py
@@ -229,6 +229,16 @@ def test_big_integer_div(self):
         self.assertIsInstance(b3, BigInteger)
         self.assertEqual(b3, 1000000)
 
+    def test_big_integer_div2(self):
+        b1 = BigInteger(41483775933600000000)
+        b2 = BigInteger(414937759336)
+
+        b3 = b1 / b2
+        b4 = b1 // b2
+        self.assertIsInstance(b3, BigInteger)
+        self.assertEqual(b3, 99975899)
+        self.assertEqual(b4, b3)
+
     def test_big_integer_float(self):
         b1 = BigInteger(5505.001)
         b2 = BigInteger(55055.999)