Use pycryptodome instead of pycrypto #45
Conversation
There was a problem hiding this comment.
The fact that pycrypto hasn't been updated in years doesn't really worry me when it comes to crypto packages once they're proven to be implemented properly. I like that the author of pycryptodome was an active contributor to the former pycrypto package. It's also nice that the block ciphers are implemented as C extensions and not pure python from a speed perspective. With some luck the pycryptodome package might add the secp256r1 ECDSA curve in the future that will allow us to deprecate ECCurve.py if it will be a C extension (as we would want to fastest implementation with regards to the network TPS increase plans).
|
This looks good, would be great if they eventually supported It looks like it has support for |
What current issue(s) does this address, or what feature is it adding?
pycrypto has not been updated in almost 4 years.
Many other packages use pycryptodome and are incompatible with pycryto. Installing neo-python-core side-by-side with such packages causes them to break.
How did you solve this problem?
Switch to pycryptodome.
How did you make sure your solution works?
Run tests
Did you add any tests?
No
Did you run
make lintandmake coverage?yes
Are there any special changes in the code that we should be aware of?
Yes, this PR should probably not be merged until the same change is made to neo-python. Although this change will not break anything in neo-python, it could cause subsequent changes that do break neo-python to go unnoticed. neo-python is harder to test (and I'm not using it), so I did not submit a PR there yet.