Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

according to C#, BigInteger(0) is b'\x00' #50

Merged

Conversation

igormcoelho
Copy link
Contributor

What current issue(s) does this address, or what feature is it adding?
I solves issue #49
How did you solve this problem?
I used Eco platform (neocompiler.io) to test both networks simultaneously (Python and C#)
How did you make sure your solution works?
I also tested locally.
Did you add any tests?
I tested locally.
Did you run make lint and make coverage?
No.
Are there any special changes in the code that we should be aware of?
No.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.934% when pulling 60e434d on igormcoelho:fix_bigint_zero_to_byte_array into 8d6ed7e on CityOfZion:master.

@metachris
Copy link
Contributor

Looks good. Could you please add a test?

@igormcoelho
Copy link
Contributor Author

igormcoelho commented May 30, 2018

Hi Chris, unfortunately I'm not an expert in python, and have never dealt with tests before...
So, this means it will take some time, until I properly understand how this works, and time is quite short right now. If you guys want to wait, it's up to you.

@metachris
Copy link
Contributor

Thanks, should be fine :) Looking to get some final feedback about possible unexpected consequences @localhuman ?

@metachris metachris merged commit 6b130f6 into CityOfZion:master May 30, 2018
@igormcoelho
Copy link
Contributor Author

Yeah, I agree Chris that this may become some kind of bomb... I dont have any idea of the consequences hahaha. But I know for sure, the sooner this is included, the better. Thanks

@igormcoelho igormcoelho deleted the fix_bigint_zero_to_byte_array branch June 1, 2018 18:36
@igormcoelho
Copy link
Contributor Author

Thanks for the attention and congratulations for the good work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants