fix contract destroy storage deletion (#996)

CityOfZion · Jul 29, 2019 · 9e8421a · 9e8421a
1 parent d49a1ad
commit 9e8421a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -61,6 +61,7 @@ All notable changes to this project are documented in this file.
 - Fix ``NOT`` VM instruction
 - Fix StackItem deserialization for ``Boolean`` VM type
 - Update ``CheckDynamicInvoke`` to operate on snapshots
+- Fix ``Contract.Destroy`` not always deleting storage
 
 
 [0.8.4] 2019-02-14

diff --git a/neo/SmartContract/StateReader.py b/neo/SmartContract/StateReader.py
@@ -617,7 +617,7 @@ def Contract_Destroy(self, engine):
 
                 to_del = []
                 for k, v in self.Snapshot.Storages.Find(hash.ToArray()):
-                    storage_key = StorageKey(script_hash=hash, key=k)
+                    storage_key = StorageKey(script_hash=hash, key=k[20:])
                     # Snapshot.Storages.Delete() modifies the underlying dictionary of the cache we'd be iterating
                     # over using Storages.Find. We therefore need to postpone deletion
                     to_del.append(storage_key)